Add more log to improve error handling for optional-logger failures#11816
Merged
JanProvaznik merged 28 commits intodotnet:mainfrom Jun 6, 2025
Merged
Add more log to improve error handling for optional-logger failures#11816JanProvaznik merged 28 commits intodotnet:mainfrom
JanProvaznik merged 28 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
… the error when run the pipeline
…inh99/msbuild into dev/huulinhnguyen/issue9560
JaynieBai
reviewed
Jun 4, 2025
JaynieBai
reviewed
Jun 4, 2025
YuliiaKovalova
approved these changes
Jun 6, 2025
surayya-MS
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Fix the issue Improve error handling for optional-logger failures #9560
Context
When using optional loggers with MSBuild, the error messages generated for invalid logger assemblies are not clear, making it difficult for users to diagnose issues.
Changes Made
Add more information for optional-logger failures
Testing
I have performed testing for various exception to validate the changes. The following cases was successfully tested: IOException, BadImageFormatException, MemberAccessException, TargetInvocationException
I was unbale to reproduce 2 cases: SecurityException, ReflectionTypeLoadException
Notes